8000 Set ideal width and height of screen sharing to 1200p maximum by SleepySquash · Pull Request #1278 · team113/messenger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set ideal width and height of screen sharing to 1200p maximum #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Set ideal width and height of screen sharing to 1200p maximum #1278

merged 1 commit into from
Jun 6, 2025

Conversation

SleepySquash
Copy link
Contributor
@SleepySquash SleepySquash commented Jun 6, 2025 •
edited
Loading

Synopsis

Browsers can output screen sharing with the native resolution of the screen, which might be too much.

Solution

This PR limits the maximum resolution of screen sharing by setting ideal constraints.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added this to the 0.6.0 milestone Jun 6, 2025
@SleepySquash SleepySquash self-assigned this Jun 6, 2025
@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code labels Jun 6, 2025
@SleepySquash
Copy link
Contributor Author

FCM

Set `idealWidth` and `idealHeight` to `1920x1200` for `DisplayVideoTrackConstraints` in `OngoingCall` (#1278)

@SleepySquash SleepySquash marked this pull request as ready for review June 6, 2025 13:20
@SleepySquash SleepySquash merged commit 6ed806a into main Jun 6, 2025
27 checks passed
@SleepySquash SleepySquash deleted the limit-ideal-resolution-to-screen-share branch June 6, 2025 14:24
github-actions bot added a commit that referenced this pull request Jun 6, 2025
@github-actions
Set idealWidth and idealHeight to 1920x1200 for `DisplayVideoTr…
c8eff0d 
…ackConstraints` in `OngoingCall` (#1278) 6ed806a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SleepySquash
0