8000 Fix `LoginController.recovery` not acknowledging data from `LoginController.login` field by SleepySquash · Pull Request #1285 · team113/messenger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix LoginController.recovery not acknowledging data from LoginController.login field #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 19, 2025
Merged

Fix LoginController.recovery not acknowledging data from LoginController.login field #1285

merged 6 commits into from
Jun 19, 2025

Conversation

SleepySquash
Copy link
Contributor
@SleepySquash SleepySquash commented Jun 17, 2025 •
edited
Loading

Synopsis

There's a bug: if you input something into login field of LoginView modal and then press Forgot password, then the Proceed button won't be clickable.

Solution

This PR fixes the issue.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added this to the 0.6.0 milestone Jun 17, 2025
@SleepySquash SleepySquash self-assigned this Jun 17, 2025
@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Jun 17, 2025
@SleepySquash
Copy link
Contributor Author

FCM

Fix `LoginController.recovery` not acknowledging data from `LoginController.login` field (#1285)

@SleepySquash SleepySquash marked this pull request as ready for review June 19, 2025 10:41
@SleepySquash SleepySquash merged commit 5f7a81e into main Jun 19, 2025
27 checks passed
@SleepySquash SleepySquash deleted the clear-caches-when-logging-out branch June 19, 2025 11:23
github-actions bot added a commit that referenced this pull request Jun 19, 2025
@github-actions
Fix LoginController.recovery not acknowledging data from `LoginCont…
0a6af0f 
…roller.login` field (#1285) 5f7a81e
SleepySquash added a commit that referenced this pull request Jun 20, 2025
@SleepySquash
Fix LoginController.recovery not acknowledging data from `LoginCont…
9179a2d 
…roller.login` field (#1285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.
1 participant
@SleepySquash
0