8000 Redesign `ChatMessage` delete popup (#1268) by ekrem-qb · Pull Request #1291 · team113/messenger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Redesign ChatMessage delete popup (#1268) #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 26, 2025
Merged

Redesign ChatMessage delete popup (#1268) #1291

merged 17 commits into from
Jun 26, 2025

Conversation

ekrem-qb
Copy link
Contributor
@ekrem-qb ekrem-qb commented Jun 24, 2025 •
edited by SleepySquash
Loading

Resolves Redesign ChatMessage delete popup (#1268)

Synopsis

Delete popup has been redesigned and should be refactored to account those changes.

Solution

This PR updates the design of normal, forwarded and selected messages delete popup

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@ekrem-qb ekrem-qb added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Jun 24, 2025
@ekrem-qb ekrem-qb requested a review from SleepySquash June 24, 2025 11:13
SleepySquash
SleepySquash requested changes Jun 24, 2025
View reviewed changes
Copy link
Contributor
@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekrem-qb, please, don't request a review before you complete all the necessary steps required for that:

  1. You should be an assignee of this PR.
  2. Let's set the milestone.
  3. FCM should be posted.
  4. Draft mode should be removed.

@ekrem-qb
Copy link
Contributor Author
ekrem-qb commented Jun 24, 2025 •
edited by SleepySquash
Loading

FCM

Redesign `ChatMessage` delete popup on `Chat` page (#1291, #1268)

Additionally:
- remove redundant `ConfirmDialog` widget

@ekrem-qb ekrem-qb marked this pull request as ready for review June 24, 2025 11:22
@ekrem-qb ekrem-qb added this to the 0.6.0 milestone Jun 24, 2025
@ekrem-qb ekrem-qb requested a review from SleepySquash June 24, 2025 11:23
SleepySquash
SleepySquash requested changes Jun 24, 2025
View reviewed changes
Copy link
Contributor
@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekrem-qb, you should be an assignee of this PR.

Screenshot 2025-06-24 at 14 41 03

@ekrem-qb ekrem-qb self-assigned this Jun 24, 2025
SleepySquash
SleepySquash requested changes Jun 24, 2025
View reviewed changes
SleepySquash
SleepySquash reviewed Jun 24, 2025
View reviewed changes
@ekrem-qb ekrem-qb requested a review from SleepySquash June 24, 2025 14:44
SleepySquash
SleepySquash requested changes Jun 25, 2025
View reviewed changes
Copy link
Contributor
@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else is LGTM 👍

@ekrem-qb ekrem-qb requested a review from SleepySquash June 25, 2025 12:13
@SleepySquash SleepySquash enabled auto-merge (squash) June 26, 2025 07:46
@SleepySquash SleepySquash merged commit 06ecfd1 into main Jun 26, 2025
27 checks passed
@SleepySquash SleepySquash deleted the 1268-redesign-delete-popup branch June 26, 2025 08:26
github-actions bot added a commit that referenced this pull request Jun 26, 2025
@github-actions
Redesign ChatMessage delete popup on Chat page (#1291, #1268)
10a490f 
Additionally:
- remove redundant `ConfirmDialog` widget 06ecfd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@ekrem-qb ekrem-qb

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Redesign ChatMessage delete popup
2 participants
@ekrem-qb @SleepySquash
0