8000 Add required `<script>` tag for `pwa_install` package to `index.html` by SleepySquash · Pull Request #1303 · team113/messenger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add required <script> tag for pwa_install package to index.html #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Add required <script> tag for pwa_install package to index.html #1303

merged 1 commit into from
Jun 27, 2025

Conversation

SleepySquash
Copy link
Contributor
@SleepySquash SleepySquash commented Jun 27, 2025 •
edited
Loading

Synopsis

PWA install button always states that PWA is either already installed or unavailable.

Solution

This is caused by pwa_install step about adding <script> tag is being ignored. This PR adds the required script to index.html file.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added this to the 0.6.0 milestone Jun 27, 2025
@SleepySquash SleepySquash self-assigned this Jun 27, 2025
@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code platform::web Specific to Web platform labels Jun 27, 2025
@SleepySquash
Copy link
Contributor Author

FCM

Add required `<script>` tag for `pwa_install` package to `index.html` (#1303)

@SleepySquash SleepySquash marked this pull request as ready for review June 27, 2025 13:58
@SleepySquash SleepySquash merged commit 85a7e00 into main Jun 27, 2025
27 checks passed
@SleepySquash SleepySquash deleted the fix-pwa-install-always-unavailable branch June 27, 2025 14:03
github-actions bot added a commit that referenced this pull request Jun 27, 2025
@github-actions
Add required <script> tag for pwa_install package to index.html (…
387e3ef 
…#1303) 85a7e00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes platform::web Specific to Web platform
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.
1 participant
@SleepySquash
0