8000 Mention Dart imports and Fluent keys sorting and grouping rules in Contribution Guide by SleepySquash · Pull Request #1315 · team113/messenger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mention Dart imports and Fluent keys sorting and grouping rules in Contribution Guide #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Mention Dart imports and Fluent keys sorting and grouping rules in Contribution Guide #1315

wants to merge 2 commits into from
+58 −0

Conversation

SleepySquash
Copy link
Contributor
@SleepySquash SleepySquash commented Jul 2, 2025 •
edited
Loading

Synopsis

We follow strict imports grouping and sorting rules. The same goes for .ftl files - the keys must be sorted alphabetically. These things may be not really obvious to the developers.

Solution

Mention and describe the rules.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added this to the 0.6.0 milestone Jul 2, 2025
@SleepySquash SleepySquash self-assigned this Jul 2, 2025
@SleepySquash SleepySquash added k::documentation Changes of project documentation enhancement Improvement of existing features or bugfix labels Jul 2, 2025
@SleepySquash
Copy link
Contributor Author
SleepySquash commented Jul 2, 2025 •
edited
Loading

FCM

Mention Dart imports and Fluent keys sorting rules in Contribution Guide (#1315)

@SleepySquash SleepySquash marked this pull request as ready for review July 3, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::documentation Changes of project documentation
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SleepySquash
0