8000 Fix `OngoingCall` sending tracks before media has finished initializing by SleepySquash · Pull Request #661 · team113/messenger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix OngoingCall sending tracks before media has finished initializing #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix OngoingCall sending tracks before media has finished initializing #661

merged 1 commit into from
Oct 18, 2023

Conversation

SleepySquash
Copy link
Contributor
@SleepySquash SleepySquash commented Oct 18, 2023 •
edited
Loading

Synopsis

OngoingCall может отправлять треки ещё до окончания инициализации медиа, из-за чего стейт не синхронизируется и получается, что пользователи могут видеть расшарку, камеру итд без понимания того, что расшарка/видео идут.

Solution

Происходит это, когда joinRoom происходит раньше, чем устанавливаются настройки треки. Решение: по умолчанию сразу после инициализации комнаты выставлять все настройки в false.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code labels Oct 18, 2023
@SleepySquash SleepySquash added this to the 0.1.0-alpha.10.1 milestone Oct 18, 2023
@SleepySquash SleepySquash self-assigned this Oct 18, 2023
@SleepySquash
Copy link
Contributor Author

FCM

Fix `OngoingCall` using default `MediaStreamSettings` after joining (#661)

Additionally:
- update `medea_flutter_webrtc` to `0.8.3-dev+rev.4622b6f7699e7205733cea57a6257fc40e2a94fa` version

@SleepySquash SleepySquash marked this pull request as ready for review October 18, 2023 16:07
@SleepySquash SleepySquash enabled auto-merge (squash) October 18, 2023 16:08
@SleepySquash SleepySquash disabled auto-merge October 18, 2023 16:13
@SleepySquash SleepySquash merged commit 663497e into main Oct 18, 2023
@SleepySquash SleepySquash deleted the fix-call-state-races branch October 18, 2023 16:13
github-actions bot added a commit that referenced this pull request Oct 18, 2023
@github-actions
Fix OngoingCall using default MediaStreamSettings after joining (#…
39c228b 
…661)

Additionally:
- update `medea_flutter_webrtc` to `0.8.3-dev+rev.4622b6f7699e7205733cea57a6257fc40e2a94fa` version 663497e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code
Projects
None yet
Milestone
0.1.0-alpha.10.1
Development

Successfully merging this pull request may close these issues.
1 participant
@SleepySquash
0