8000 Fix `ChatEvents` may be ignored (#777) by krida2000 · Pull Request #784 · team113/messenger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix ChatEvents may be ignored (#777) #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jan 19, 2024
Merged

Fix ChatEvents may be ignored (#777) #784

merged 27 commits into from
Jan 19, 2024

Conversation

krida2000
Copy link
Contributor
@krida2000 krida2000 commented Jan 5, 2024 •
edited by SleepySquash
Loading

Resolve #777

Synopsis

Иногда при входе в приложение можно увидеть что часть ивентов чата не обработалась.

Solution

Баг будет исправлен.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jan 5, 2024
@krida2000 krida2000 added this to the 0.1.0-alpha.12 milestone Jan 5, 2024
@krida2000 krida2000 self-assigned this Jan 5, 2024
@krida2000
Copy link
Contributor Author
krida2000 commented Jan 8, 2024 •
edited by SleepySquash
Loading

FCM

Use `updateVersion` in `ChatRepository` to fix `ChatEvent`s being ignored (#784, #777)

Additionally:
- impl `HiveLazyProvider.txn` to put `Chat`s to Hive in transactions

@krida2000 krida2000 requested a review from SleepySquash January 8, 2024 08:02
@krida2000 krida2000 marked this pull request as ready for review January 8, 2024 08:44
SleepySquash
SleepySquash reviewed Jan 8, 2024
View reviewed changes
SleepySquash
SleepySquash requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor
@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обсудили: почему-то не сохраняется версия чата при получении чатом событий, каждый раз при рефреше происходит переподписка с одной и той же версией.

krida2000
krida2000 commented Jan 9, 2024
View reviewed changes
krida2000
krida2000 commented Jan 11, 2024
View reviewed changes
@SleepySquash SleepySquash mentioned this pull request Jan 12, 2024
Draft
14 tasks
@SleepySquash
Copy link
Contributor

@krida2000, у Вас что-то сложное получается. Часто встречал .txn(() async {}) или runTx(() async {}) или transaction(() async {}) реализации транзакций, они сильно проще и понятнее, чем какие-то ID передавать туда-сюда. Не получился ли так сделать? Пример: https://pub.dev/packages/postgres
Или у isar'а, кстати, были транзакции тоже. Там .txn(), вроде бы.

krida2000
krida2000 commented Jan 16, 2024
View reviewed changes
SleepySquash
SleepySquash reviewed Jan 17, 2024
View reviewed changes
@SleepySquash SleepySquash added k::refactor Refactor changes of existing code and removed k::UI/UX UI (user interface) and UX (user experience) changes labels Jan 19, 2024
@SleepySquash SleepySquash merged commit a9929a2 into main Jan 19, 2024
@SleepySquash SleepySquash deleted the 777-fix-chat-events-ignoring branch January 19, 2024 07:52
github-actions bot added a commit that referenced this pull request Jan 19, 2024
@github-actions
Use updateVersion in ChatRepository to fix ChatEvents being ign…
9c22160 
…ored (#784, #777)

Additionally:
- impl `HiveLazyProvider.txn` to put `Chat`s to Hive in transactions a9929a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code
Projects
None yet
Milestone
0.1.0-alpha.12
Development

Successfully merging this pull request may close these issues.

Incoming OngoingCalls might get displayed and never closed, despite being finished
2 participants
@krida2000 @SleepySquash
0