8000 Messages might stuck at last, not loading the rest, despite `Chat.lastItem` changed (#691) by krida2000 · Pull Request #990 · team113/messenger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Messages might stuck at last, not loading the rest, despite Chat.lastItem changed (#691) #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2024
Merged

Messages might stuck at last, not loading the rest, despite Chat.lastItem changed (#691) #990

merged 6 commits into from
May 9, 2024

Conversation

krida2000
Copy link
Contributor
@krida2000 krida2000 commented May 8, 2024 •
edited by SleepySquash
Loading

Resolves #691

Synopsis

Иногда новые сообщения могут не повиться в чате.

Solution

Проблема будет исправлена.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code labels May 8, 2024
@krida2000 krida2000 added this to the 0.1.0-alpha.14 milestone May 8, 2024
@krida2000 krida2000 self-assigned this May 8, 2024
krida2000
krida2000 commented May 8, 2024
View reviewed changes
@krida2000 krida2000 changed the title Messages might stuck at last, not loading the rest, despite Chat.lastItem changed Messages might stuck at last, not loading the rest, despite Chat.lastItem changed (#691) May 8, 2024
@krida2000
Copy link
Contributor Author
krida2000 commented May 8, 2024 •
edited by SleepySquash
Loading

FCM

Don't persist `Chat`s to Hive in popup `Call`s (#990, #691)

@krida2000 krida2000 marked this pull request as ready for review May 8, 2024 10:27
@krida2000 krida2000 requested a review from SleepySquash May 8, 2024 10:27
SleepySquash
SleepySquash reviewed May 8, 2024
View reviewed changes
@SleepySquash SleepySquash merged commit 5eaa774 into main May 9, 2024
@SleepySquash SleepySquash deleted the 691-fix-messages-might-not-showed-in-chat branch May 9, 2024 08:58
github-actions bot added a commit that referenced this pull request May 9, 2024
@github-actions
Don't persist Chats to Hive in popup Calls (#990, #691) 5eaa774
a064d7f
This was referenced May 10, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code
Projects
None yet
Milestone
0.1.0-alpha.13.5
Development

Successfully merging this pull request may close these issues.

Messages might stuck at last, not loading the rest, despite Chat.lastItem changed
2 participants
@krida2000 @SleepySquash
0