8000 Update mkl.cmake by tempdist · Pull Request #1 · tempdist/Open3D · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update mkl.cmake #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update mkl.cmake #1

wants to merge 1 commit into from

Conversation

tempdist
Copy link
Owner
@tempdist tempdist commented Jul 3, 2024

mkl.cmake MKL_INCLUDE_DIR link typo fixed

  • [ x ] Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

cmake --target INSTALL fails in case mkl needs to download a package on windows 11

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • [ x ] I will follow up and update the code if CI fails.
  • [ x ] For fork PRs, I have selected Allow edits from maintainers.

Description

mkl.cmake file has MKL_INCLUDE_DIR attribute first link typo error--bz2 is mistyped as bz2W--at line 15. When this MKL_INCLUDE_DIR is left with typo error, cmake --target ## INSTALL fails soon as a mkl related package needs download. Hence, without this insignificant change, cmake install fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tempdist
0