8000 Add http routes for add/remove search attributes by Alex-Tideman · Pull Request #607 · temporalio/api · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add http routes for add/remove search attributes #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alex-Tideman
Copy link

READ BEFORE MERGING: All PRs require approval by b 8000 oth Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.

What changed?
Add HTTP route for adding and removing search attributes

Why?

Breaking changes

Server PR

@Alex-Tideman Alex-Tideman requested review from a team as code owners June 27, 2025 14:36
Copy link
Member
@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But you probably need to re-run the OpenAI generator stuff. Would be eager to remove the /api/v1 endpoints at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0