8000 Test Server times out workflow task in case of workflow task failure after the second attempt by Spikhalskiy · Pull Request #1124 · temporalio/sdk-java · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test Server times out workflow task in case of workflow task failure after the second attempt #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2022
Merged

Test Server times out workflow task in case of workflow task failure after the second attempt #1124

merged 1 commit into from
Apr 11, 2022

Conversation

Spikhalskiy
Copy link
Contributor
@Spikhalskiy Spikhalskiy commented Apr 10, 2022 •
edited
Loading

What was changed

To match the new behavior of the real server, Test Server now times out a workflow task if the workflow task failed and the attempt is >=2.

Why?

See temporalio/temporal#2548

How it was tested

New unit test verifying the behavior across the test and real server.

@Spikhalskiy Spikhalskiy force-pushed the test-server-timeout-wft-on-second-failure branch from 270c024 to d39dfd8 Compare April 10, 2022 16:34
@Spikhalskiy Spikhalskiy marked this pull request as ready for review April 10, 2022 16:34
@Spikhalskiy Spikhalskiy force-pushed the test-server-timeout-wft-on-second-failure branch 2 times, most recently from e566c25 to 11d3ef5 Compare April 10, 2022 17:12
@Spikhalskiy Spikhalskiy force-pushed the test-server-timeout-wft-on-second-failure branch from 11d3ef5 to 880bee0 Compare April 10, 2022 17:18
@Spikhalskiy Spikhalskiy added this to the 1.9.0 milestone Apr 11, 2022
@Spikhalskiy Spikhalskiy mentioned this pull request Apr 11, 2022
Merged
3 tasks
@Spikhalskiy Spikhalskiy changed the title Test Server times out workflow task in case of workflow task failure after second attempt Test Server times out workflow task in case of workflow task failure after the second attempt Apr 11, 2022
@Spikhalskiy Spikhalskiy merged commit f706bd0 into temporalio:master Apr 11, 2022
@Spikhalskiy Spikhalskiy deleted the test-server-timeout-wft-on-second-failure branch April 15, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

@mfateev mfateev Awaiting requested review from mfateev

@Sushisource Sushisource Awaiting requested review from Sushisource

@bergundy bergundy Awaiting requested review from bergundy

@mmcshane mmcshane Awaiting requested review from mmcshane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Spikhalskiy @cretz
0