Add RebuildMutableState API #2532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Feb 23, 2022
yiminc
approved these changes
Feb 23, 2022
Comment on lines
+452
to
+454
| if err != nil { | ||
| return nil, adh.error(err, scope) | ||
| } |
yycptt
approved these changes
Feb 23, 2022
| // note: this is an admin API, for operator to recover a corrupted mutable state, so state transition count | ||
| // should remain the same, the -= 1 exists here since later CloseTransactionAsSnapshot will += 1 to state transition count | ||
| rebuildMutableState.GetExecutionInfo().StateTransitionCount = stateTransitionCount - 1 | ||
| rebuildMutableState.SetUpdateCondition(rebuildMutableState.GetNextEventID(), dbRecordVersion) |
There was a problem hiding this comment.
If next eventID in db is corrupted, does it mean the update will fail?
Shall we use the nextEvenID in msRecord here?
There was a problem hiding this comment.
we stop using next event ID as CAS condition ~6 months ago, we should do more cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
This API allows operator to rebuild the mutable state using persisted history events, in case DB corruption ever occurs.
How did you test it?
Integration test
Potential risks
N/A
Is hotfix candidate?
No