8000 Unify history task persistence range query behavior by yycptt · Pull Request #2547 · temporalio/temporal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unify history task persistence range query behavior #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 28, 2022
Merged

Unify history task persistence range query behavior #2547

merged 6 commits into from
Feb 28, 2022

Conversation

yycptt
Copy link
Member
@yycptt yycptt commented Feb 25, 2022

What changed?

  • Make range based on TaskID and task fire time both [inclusive, exclusive)
  • Two bug fix for replication task API

Why?

  • Unify behavior
  • bug fix

How did you test it?

  • Existing test & added new test for bug fix

Potential risks

  • get tasks and range delete may miss some tasks

Is hotfix candidate?
no

@yycptt yycptt requested review from yux0, wxing1292 and yiminc February 25, 2022 18:10
@yycptt yycptt requested a review from a team as a code owner February 25, 2022 18:10
yycptt
yycptt commented Feb 25, 2022
View reviewed changes
@yycptt yycptt mentioned this pull request Feb 25, 2022
Closed
yiminc
yiminc reviewed Feb 26, 2022
View reviewed changes
@yycptt yycptt merged commit c3e7dbe into temporalio:master Feb 28, 2022
@yycptt yycptt deleted the inclusive-exclusive branch February 28, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@yux0 yux0 Awaiting requested review from yux0

@wxing1292 wxing1292 Awaiting requested review from wxing1292

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yiminc
0