[docs] improve documentation for building images #2557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreiding
reviewed
Feb 28, 2022
docker/README.md
Outdated
|
|
||
| To run docker image with dependencies: | ||
| * [docker-compose](https://docs.docker.com/compose/install/) | ||
| To *run* the docker image with dependencies (e.g. PostgreSQL and Elasticsearch), you can use `docker-compose`. See our [docker-compose repo](https://github.com/temporalio/docker-compose) for reference configurations. |
There was a problem hiding this comment.
There is still a missing piece to use the locally built images.
The tags in the docker compose need to be updated to test
Assuming that is the goal of the update, build locally and make use of those built images.
Line 41 in f6e84df
There was a problem hiding this comment.
nice catch thank you, edited
There was a problem hiding this comment.
On this topic, I think its time to add a .env file to the docker-compose repo.
It would be simpler to override the tag and for version updates as well.
jbreiding
reviewed
Feb 28, 2022
jbreiding
reviewed
Feb 28, 2022
Co-authored-by: Jeremy Breiding <jbreiding@users.noreply.github.com>
Co-authored-by: Jeremy Breiding <jbreiding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
improve documentation for building images
Why?
when i was working on auto-setup, it was not obvious from the readme that the main way to build the image was to run
makeat the project root, until Alex told me.How did you test it?
Potential risks
Is hotfix candidate?