Bump SDK. #2601
Merged
Bump SDK. #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems this needs more work to allow tests to run. |
|
This require some extra work to fix the dependency issue. #2597 |
|
This should be possible now if you rebase on master. Unless I mixed up ours vs theirs. |
|
This is now ready to review. Thanks @jbreiding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Bumped SDK version and made required changes.
Why?
To make repo compatible with latest SDK so that code which uses both can compile (tctl for example).
How did you test it?
Built tctl with this change.
Potential risks
None.
Is hotfix candidate?
No.