Fix replication error handling #2624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Mar 22, 2022
| ) | ||
| switch resendErr.(type) { | ||
| case *serviceerror.NotFound: | ||
| // TODO" cleanup history |
There was a problem hiding this comment.
should not worry about history cleanup, it should be handled by the delete history timer task already, or the history GC should handle it.
There was a problem hiding this comment.
Synced offline. This cannot handle by GC. We need to delete the workflow. I will separate it to a new PR
yiminc
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix replication error handling
Why?
How did you test it?
Local
Potential risks
Some no op tasks will be put into DLQ
Is hotfix candidate?
Yes