Add DeleteNamespace API #2645
Merged
Add DeleteNamespace API #2645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa10b88 to
f40e139
Compare
|
API changes is here: temporalio/api#166 |
alexshtin
commented
Mar 25, 2022
Comment on lines
+306
to
+307
| DeleteActivityRPS: h.config.DeleteNamespaceDeleteActivityRPS(), | ||
| ConcurrentDeleteExecutionsActivities: h.config.DeleteNamespaceConcurrentDeleteExecutionsActivities(), |
There was a problem hiding this comment.
DeleteExecutionsConfig has 4 fields. I decided to expose these two through dynamic config and other 2 just leave workflow defaults.
There was a problem hiding this comment.
why use dynamic config for this? It would be much easier to just pass in as input.
93f0b1d to
1b8526b
Compare
yiminc
reviewed
Mar 26, 2022
| @@ -217,6 +217,13 @@ const ( | |||
| // of Timeout and if no activity is seen even after that the connection is closed. | |||
| KeepAliveTimeout = "frontend.keepAliveTimeout" | |||
|
|
|||
| // DeleteNamespaceDeleteActivityRPS is RPS per every parallel delete executions activity. | |||
| // Total RPS is equal to DeleteNamespaceDeleteActivityRPS * DeleteNamespaceConcurrentDeleteExecutionsActivities. | |||
| DeleteNamespaceDeleteActivityRPS = "frontend.deleteNamespaceDeleteActivityRPS" | |||
There was a problem hiding this comment.
why is this frontend dynamic config?
Comment on lines
+306
to
+307
| DeleteActivityRPS: h.config.DeleteNamespaceDeleteActivityRPS(), | ||
| ConcurrentDeleteExecutionsActivities: h.config.DeleteNamespaceConcurrentDeleteExecutionsActivities(), |
There was a problem hiding this comment.
why use dynamic config for this? It would be much easier to just pass in as input.
yiminc
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add DeleteNamespace API.
Why?
Expose DeleteNamespace feature.
How did you test it?
Invoke API manually but will add intergration tests later.
Potential risks
No risks.
Is hotfix candidate?
No.