8000 Add sqlite persistence tests by jbreiding · Pull Request #2681 · temporalio/temporal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add sqlite persistence tests #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Add sqlite persistence tests #2681

merged 3 commits into from
Mar 30, 2022

Conversation

jbreiding
Copy link
Contributor

What changed?
Adding sqlite persistence tests

Why?
Because validation is good

How did you test it?
Heh

Potential risks

Is hotfix candidate?

@jbreiding jbreiding requested a review from a team as a code owner March 30, 2022 15:56
@jbreiding jbreiding enabled auto-merge (squash) March 30, 2022 16:01
Copy link
Member
@yiminc yiminc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbreiding jbreiding disabled auto-merge March 30, 2022 19:21
@@ -264,6 +264,5 @@ func (mdb *db) PruneClusterMembership(
templatePruneStaleClusterMembership,
constMembershipPartition,
mdb.converter.ToSQLiteDateTime(filter.PruneRecordsBefore),
filter.MaxRecordsAffected,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we create an issue or add a TODO for removing this field from the filter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think we need to revisit all of these sqlplugins

this copy/pasta issue needs to be prevented with some code-gen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably just do that with this PR.

@yiminc thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the field for the filter only for sql plugin.

@@ -123,21 +123,22 @@ func (s *RetrySuite) TestIsRetryableSuccess() {

func (s *RetrySuite) TestIsRetryableFailure() {
i := 0
theErr := someError{}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test consistently fails for me.

So adding a fix.

@jbreiding jbreiding enabled auto-merge (squash) March 30, 2022 19:55
@jbreiding jbreiding disabled auto-merge March 30, 2022 19:57
@jbreiding jbreiding enabled auto-merge (squash) March 30, 2022 20:02
@jbreiding jbreiding merged commit 306eda8 into temporalio:master Mar 30, 2022
@jbreiding jbreiding deleted the sqlite-persistence-tests branch March 30, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0