-
Notifications
You must be signed in to change notification settings - Fork 1k
Add sqlite persistence tests #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sqlite persistence tests #2681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -264,6 +264,5 @@ func (mdb *db) PruneClusterMembership( | |||
templatePruneStaleClusterMembership, | |||
constMembershipPartition, | |||
mdb.converter.ToSQLiteDateTime(filter.PruneRecordsBefore), | |||
filter.MaxRecordsAffected, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we create an issue or add a TODO for removing this field from the filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think we need to revisit all of these sqlplugins
this copy/pasta issue needs to be prevented with some code-gen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should probably just do that with this PR.
@yiminc thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the field for the filter only for sql plugin.
@@ -123,21 +123,22 @@ func (s *RetrySuite) TestIsRetryableSuccess() { | |||
|
|||
func (s *RetrySuite) TestIsRetryableFailure() { | |||
i := 0 | |||
theErr := someError{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test consistently fails for me.
So adding a fix.
What changed?
Adding sqlite persistence tests
Why?
Because validation is good
How did you test it?
Heh
Potential risks
Is hotfix candidate?