Only decode on onMount to prevent overfetching payloads #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
added a commit
that referenced
this pull request
May 29, 2025
This reverts commit 2f78a89.
Alex-Tideman
added a commit
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Because our decoder was reactive to value, even though the value didn't change it was still triggered due to JSON.stringify. Moving to onMount will decode only on the mount of component, ensuring it doesn't over-decode. The value shouldn't change - payloads are immutable in history - so onMount should always work. It's more apparent when the workflow is running and we refetch the workflow or get new events in the event history poll.
Screenshots (if applicable) 📸
Before
BeforeDecodeFix.mov
After
AfterDecodeFix.mov
Design Considerations 🎨
Testing 🧪
To test:
Use samples-typescript/encryption project
Add
await condition(() => false)before thereturn resultsin the workflows.ts to keep the workflow running.Turn on the codec server. Decode calls should only happen on page load or when new event is rendered. If you sit on the page, it should not re-request codec calls.
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?