8000 use string instead of null for dark mode system setting by andrewzamojc · Pull Request #2751 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use string instead of null for dark mode system setting #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

use string instead of null for dark mode system setting #2751

merged 1 commit into from
May 29, 2025

Conversation

andrewzamojc
Copy link
Contributor
@andrewzamojc andrewzamojc commented May 29, 2025 •
edited
Loading

Description & motivation 💭

While releasing to cloud-ui, manual testing revealed that the "System Default" setting for dark mode was not persisting. This is because the DarkModePreference type was boolean | null where null represents "system default." However, passing null to local storage removes the key (local storage is string based).

This PR updates the DarkModePreference type to be boolean | 'system', which works with local storage.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@vercel Vercel
Copy link
vercel bot commented May 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 5:01pm

@andrewzamojc andrewzamojc marked this pull request as ready for review May 29, 2025 17:04
@andrewzamojc andrewzamojc merged commit afa0e8e into main May 29, 2025
20 checks passed
@andrewzamojc andrewzamojc deleted the DT-2854-3-fix-persist-dark-mode-preference branch May 29, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Tideman Alex-Tideman Alex-Tideman approved these changes

@rossedfort rossedfort Awaiting requested review from rossedfort rossedfort is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewzamojc @Alex-Tideman
0