[DT-2854] add an integration test to make sure dark mode toggling works through localstorage #2752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andrewzamojc
commented
May 29, 2025
| @@ -35,5 +35,6 @@ | |||
| label={buttonText} | |||
| icon={buttonIcon} | |||
| on:click={cycleDarkModePreference} | |||
| data-testid="dark-mode-icon-button" | |||
There was a problem hiding this comment.
Annotation: Since the aria-label changes when you press the button, getByRole doesn't work well without re-selecting over and over. By using testid, I can get the element once and use it throughout the test.
ea6d9c3 to
0bf1034
Compare
andrewzamojc
commented
May 30, 2025
| @@ -25,6 +25,7 @@ | |||
| <div | |||
| class="flex h-6 w-6 items-center after:absolute after:left-[calc(100%_+_1.5rem)] after:top-0 after:hidden after:h-8 after:items-center after:bg-slate-800 after:p-1 after:px-2 after:text-xs after:text-white after:content-[attr(data-tooltip)] group-data-[nav=closed]:hover:after:flex" | |||
| data-tooltip={tooltip} | |||
| aria-hidden="true" | |||
There was a problem hiding this comment.
Annotation: This icon is pure decoration / redundant information to a non-visual user. By aria-hiding it, the navigation button now has a clean accessible name.
Alex-Tideman
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
A previous PR introduced the "System Default" dark mode setting. This didn't write correctly to local storage, and needed a fix, which is already merged. This PR tests that the fix is working.
Thanks team for already having a way to separate desktop and mobile test!
Thanks AI for the boilerplate and thanks @rossnelson for helping make it actually work. Humans rule!
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?