8000 Uplift third_party/tt-metal to 41ce500767a364f66034f6924837dabc133e8d4d 2025-06-04 by vmilosevic · Pull Request #3669 · tenstorrent/tt-mlir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Uplift third_party/tt-metal to 41ce500767a364f66034f6924837dabc133e8d4d 2025-06-04 #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

Uplift third_party/tt-metal to 41ce500767a364f66034f6924837dabc133e8d4d 2025-06-04 #3669

merged 2 commits into from
Jun 4, 2025

Conversation

vmilosevic
Copy link
Contributor
@vmilosevic vmilosevic commented Jun 4, 2025 •
edited by brataTT
Loading

This PR uplifts the third_party/tt-metal to the 41ce500767a364f66034f6924837dabc133e8d4d

@vmilosevic vmilosevic requested a review from a team as a code owner June 4, 2025 07:01
@codecov-commenter
Copy link
codecov-commenter commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.56%. Comparing base (64a50be) to head (63e4dec).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3669      +/-   ##
==========================================
- Coverage   72.65%   72.56%   -0.09%     
==========================================
  Files         211      211              
  Lines       28952    28978      +26     
==========================================
- Hits        21035    21028       -7     
- Misses       7917     7950      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brataTT brataTT requested review from arminaleTT and a team as code owners June 4, 2025 12:22
@mtopalovicTT
Copy link
Contributor

I'm pretty sure that emitc is not going to compile also. This would require that each user which links against _ttnn.so should manually link python for no apparent reason. Are these dependencies coming from ttnn pybind?

@brataTT
Copy link
Contributor
brataTT commented Jun 4, 2025

I'm pretty sure that emitc is not going to compile also. This would require that each user which links against _ttnn.so should manually link python for no apparent reason. Are these dependencies coming from ttnn pybind?

you're right, I'm getting the error from emitc unittests as well in local now after trying to run regtests.
surprisingly, I don't see any errors from standalone.
it's triggered by this metal change: tenstorrent/tt-metal@489eea8