8000 add constraint APIs for MaximumOp and MinimumOp by sgholamiTT · Pull Request #3673 · tenstorrent/tt-mlir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add constraint APIs for MaximumOp and MinimumOp #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

add constraint APIs for MaximumOp and MinimumOp #3673

merged 2 commits into from
Jun 9, 2025

Conversation

sgholamiTT
Copy link
Contributor

Ticket

#3639

Problem description

Missing support for constraint API for ttnn::maximum.

What's changed

This PR:

  • Adds constraint APIs for MaximumOp,
  • Adds constraint APIs for MinimumOp,
  • Commonizes some code in TTNNOpModelInterface.

Checklist

  • New/Existing tests provide coverage for changes

@sgholamiTT sgholamiTT requested a review from gfengTT June 4, 2025 17:38
@sgholamiTT sgholamiTT requested review from arminaleTT and a team as code owners June 4, 2025 17:38
@codecov-commenter
Copy link
codecov-commenter commented Jun 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 72.59%. Comparing base (25fc83b) to head (f152509).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/Dialect/TTNN/IR/TTNNOpModelInterface.cpp 0.00% 49 Missing ⚠️
lib/OpModel/TTNN/TTNNOpModel.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3673      +/-   ##
==========================================
- Coverage   72.61%   72.59%   -0.02%     
==========================================
  Files         211      211              
  Lines       28978    28979       +1     
==========================================
- Hits        21041    21036       -5     
- Misses       7937     7943       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gfengTT
gfengTT reviewed Jun 4, 2025
View reviewed changes
azecevicTT
azecevicTT approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor
@azecevicTT azecevicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialect changes looks great, this is very nice!

rpavlovicTT
rpavlovicTT reviewed Jun 9, 2025
View reviewed changes
@sgholamiTT sgholamiTT merged commit ea8de72 into main Jun 9, 2025
61 checks passed
@sgholamiTT sgholamiTT deleted the sgholami/maximumOp branch June 9, 2025 13:19
@sgholamiTT sgholamiTT mentioned this pull request Jun 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpavlovicTT rpavlovicTT rpavlovicTT approved these changes

@gfengTT gfengTT gfengTT left review comments

@arminaleTT arminaleTT arminaleTT approved these changes

@azecevicTT azecevicTT azecevicTT approved these changes

@odjuricicTT odjuricicTT Awaiting requested review from odjuricicTT odjuricicTT is a code owner automatically assigned from tenstorrent/forge-developers-mlir-optimizer

@svuckovicTT svuckovicTT Awaiting requested review from svuckovicTT svuckovicTT is a code owner automatically assigned from tenstorrent/forge-developers-mlir-core

@sdjordjevicTT sdjordjevicTT Awaiting requested review from sdjordjevicTT sdjordjevicTT is a code owner automatically assigned from tenstorrent/forge-developers-mlir-core

@mtopalovicTT mtopalovicTT Awaiting requested review from mtopalovicTT mtopalovicTT is a code owner automatically assigned from tenstorrent/forge-developers-mlir-core

@jserbedzijaTT jserbedzijaTT Awaiting requested review from jserbedzijaTT jserbedzijaTT is a code owner automatically assigned from tenstorrent/forge-developers-mlir-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sgholamiTT @codecov-commenter @rpavlovicTT @gfengTT @arminaleTT @azecevicTT
0