ttir-builder and tests updates/clean-up #3684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3684 +/- ##
==========================================
- Coverage 72.66% 72.59% -0.08%
==========================================
Files 211 211
Lines 28997 28997
==========================================
- Hits 21070 21049 -21
- Misses 7927 7948 +21 ☔ View full report in Codecov by Sentry. |
tapspatel
approved these changes
Jun 5, 2025
ctodTT
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
No issue, just changing a few tests and cleaning up.
Problem description
test_ttir_ops.pyneeded updating.What's changed
ttir.prod: no longer throwing device datatype mismatch, failing golden, added to pcc errors issuettir.upsample2d: no longer throwing device datatype mismatch, throwing new error:program-level output doesn't match golden shape! golden_shape=torch.Size([10, 64, 64, 12]), output_shape=torch.Size([10, 128, 128, 3])ttir.embedding: Changed test datatypes, only float32, int32, and unsigned ints are currently supported for golden comparisons. Now failing PCCttir.update_cache: Changed test datatypes, only float32, int32, and unsigned ints are currently supported for golden comparisons. Now throwing error:Statically allocated circular buffers on core range [(x=0,y=0) - (x=7,y=3)] grow to 2587616 B which is beyond max L1 size of 1499136 Bttir.get_dimension_size: no longer throwing device datatype mismatch, now failing PCCttir.argmax: Only supports last dimension, removed a test, now failing PCCttir.typecast: Changed test datatypes, PCC errors were because pytorch provides limited support for unsigned datatypesttir.where: Changed test datatypes, doesn't support int8, now passesChecklist