8000 fix: set an implicit root in external build if parents are not set by usamoi · Pull Request #147 · tensorchord/VectorChord · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: set an implicit root in external build if parents are not set #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: set an implicit root in external build if parents are not set #147

merged 1 commit into from
Dec 23, 2024

Conversation

usamoi
Copy link
Contributor
@usamoi usamoi commented Dec 23, 2024

No description provided.

@VoVAllen
Copy link
Member
VoVAllen commented Dec 23, 2024 •
edited
Loading

Add some e2e tests, use ai to generate it if needed

@cutecutecat
Copy link
Member

Thanks, or maybe you can merge it straightly, and I would write the tests together with the type check PR.

@usamoi usamoi requested a review from cutecutecat December 23, 2024 09:11
cutecutecat
cutecutecat approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member
@cutecutecat cutecutecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usamoi usamoi merged commit 6335852 into tensorchord:main Dec 23, 2024
9 checks passed
@usamoi usamoi mentioned this pull request Jan 8, 2025
Merged
usamoi added a commit that referenced this pull request Jan 8, 2025
@usamoi
fix: pick feat back to vchordrqfscan (#162)
e26e5e3 
pick #106, #147 and #149 to vchordrqfscan

Signed-off-by: usamoi <usamoi@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cutecutecat cutecutecat cutecutecat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usamoi @VoVAllen @cutecutecat
0