feat: rerank by fetching vectors in heap table #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b8d53f to
428aa39
Compare
dbd2576 to
6f30472
Compare
Signed-off-by: usamoi <usamoi@outlook.com>
6f30472 to
b637c0f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new reranking feature by introducing both index‐ and heap‐based rerank methods, while also updating tuple formats and configuration options to support this functionality and adjusting related workflows.
- Introduces new rerank functions (rerank_index and rerank_heap) in the algorithm crate
- Updates tuple version and metadata to include rerank_in_heap support
- Adjusts configuration options, search function error handling, and CI workflows for new environments
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/algorithm/src/rerank.rs | Implements and exports rerank_index and rerank_heap functions |
| .github/workflows/check.yml | Adds conditional steps for ubuntu-24.04 and ubuntu-24.04-arm runners |
| src/index/am/am_build.rs | Updates sample extraction logic with labeled block usage |
| src/index/gucs.rs | Refines probe extraction logic |
| crates/algorithm/src/insert.rs | Applies conditional handling based on rerank_in_heap flag |
| src/index/types.rs | Modifies validation for internal build options and tuple fields |
| crates/algorithm/src/lib.rs | Exports new rerank functions and introduces the RerankMethod enum |
| crates/algorithm/src/tuples.rs | Updates tuple version from 1 to 2 and adds rerank_in_heap field |
| crates/algorithm/src/search.rs | Adjusts search function return type and error handling for probe counts |
| crates/k_means/src/lib.rs | Adds edge-case handling in quick_centers |
| crates/algorithm/src/types.rs | Adds new rerank_in_table configuration field to index options |
| crates/algorithm/src/build.rs | Passes rerank configuration into the build process |
Comments suppressed due to low confidence (1)
src/index/am/am_build.rs:135
- [nitpick] Consider using a more descriptive label instead of 'a to improve code clarity and maintainability.
let samples = 'a: {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #136