fix: Remove graph access in ssh #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
kemingy
approved these changes
Dec 7, 2022
AlexXi19
pushed a commit
to AlexXi19/envd
that referenced
this pull request
Dec 12, 2022
* fix: Remove graph access in ssh Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Fix lint Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Update gomod Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Remove unused field Signed-off-by: Ce Gao <cegao@tensorchord.ai> Signed-off-by: Ce Gao <cegao@tensorchord.ai> Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to remove hard-coded default graph access in ssh attach
The previous implementation uses ssh command request to create the connection. This PR is to use session shell request to do it.
Then there is no need to provide the shell program name here.
Signed-off-by: Ce Gao cegao@tensorchord.ai