feat: file sync #1416
Merged
feat: file sync #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: Alex Xi <68758451+AlexXi19@users.noreply.github.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: Alex Xi <68758451+AlexXi19@users.noreply.github.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
|
Thanks for your contribution! 🎉 👍 Is this ready to review? |
|
@gaocegege it's ready |
|
Things to be discussed:
|
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: Alex Xi <68758451+AlexXi19@users.noreply.github.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
|
addressed comments cc @kemingy |
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
VoVAllen
requested changes
Jan 31, 2023
There was a problem hiding this comment.
Please also add syncthing option at the envd-server side
- https://github.com/tensorchord/envd-server/blob/main/api/types/environment.go#L37 Add a new option here
- Pass the option from client at
Line 281 in aab7f53
- Add syncthing option in EnvdServerSource
Line 57 in 56d25a0
- Pass syncthing flag through
Line 137 in d8e16a1
And also modify the server part, to ensure the git clone logic is not affected is syncthing option is not specified
|
And also please resolve the conflicts. Thanks! |
|
/cc @kemingy |
kemingy
reviewed
Feb 1, 2023
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
|
@VoVAllen waiting on |
|
I will create a new release today. |
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
|
@VoVAllen updated dependencies, now its all passing :) |
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
|
Will resolve conflicts later today. |
VoVAllen
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File sync
Syncs the user's local project directory to a pod in the kubernetes cluster started by
envd runwithenvd-server.Steps
Waiting for config to apply
Applying configurations through the syncthing rest api is async so we use the event api and wait until we see a config apply success event
What's not included and known limitations
getFreePorts. This change should be pretty easySyncthing process management
ctrl-candctrl-dWhat's next
envd attachfor starting up the sync and port forwarding againTesting
Would like some opinion on what's are the final tests to keep in the repo.