10000 ci: Remove rowserrcheck linter to avoid warning by terrytangyuan · Pull Request #1485 · tensorchord/envd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: Remove rowserrcheck linter to avoid warning #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

ci: Remove rowserrcheck linter to avoid warning #1485

merged 1 commit into from
Feb 17, 2023

Conversation

terrytangyuan
Copy link
Member

This will get rid of the warning when running lint check:

 level=warning msg="[linters_context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649

@terrytangyuan
ci: Remove rowserrcheck linter to avoid warning
7a1791b 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@kemingy kemingy merged commit 8c3e97a into tensorchord:main Feb 17, 2023
@terrytangyuan terrytangyuan deleted the rm-check branch February 17, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemingy kemingy kemingy approved these changes

@VoVAllen VoVAllen Awaiting requested review from VoVAllen VoVAllen is a code owner

@gaocegege gaocegege Awaiting requested review from gaocegege gaocegege is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrytangyuan @kemingy
0