feat: Allow buildkit timeout to be configurable #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhizhen
reviewed
Feb 17, 2023
|
@hezhizhen Great suggestions! Updated. |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
b605a82 to
7c38416
Compare
hezhizhen
reviewed
Feb 17, 2023
hezhizhen
reviewed
Feb 17, 2023
| assert.Equal(t, time.Second, GetDurationWithDefault("", time.Second), "default value") | ||
| t.Setenv("FOO", "bar") | ||
| assert.Panics(t, func() { GetDurationWithDefault("FOO", time.Second) }, "bad value") | ||
| t.Setenv("FOO", "1h") |
There was a problem hiding this comment.
How about using the actual environment variable name?
There was a problem hiding this comment.
This is intentional. This is a generic util so I prefer to use something more generic.
hezhizhen
reviewed
Feb 17, 2023
| if err == nil { | ||
| return d | ||
| } | ||
| log.WithField(key, v).WithError(err).Panic("failed to parse") |
There was a problem hiding this comment.
Will Panic() panic here?
There was a problem hiding this comment.
Yes it's intentional since we don't want users to assume that the incorrect config is applied when actually not.
|
PTAL @hezhizhen |
|
LGTM |
|
Thanks for your contribution! 🎉 👍 And Thank @hezhizhen for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was needed for me to get everything to run. I'd imagine other users might benefit from this as well.