8000 feat: bring apt-source compilation earlier by n063h · Pull Request #1554 · tensorchord/envd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: bring apt-source compilation earlier #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2023
Merged

feat: bring apt-source compilation earlier #1554

merged 1 commit into from
Apr 10, 2023

Conversation

n063h
Copy link
Contributor
@n063h n063h commented Apr 10, 2023

refer to #1553

The change is to bring apt-source compilation earlier which allow some packages installed in

	if g.Dev {
		dev := g.compileDevPackages(aptMirror)
		sshd := g.compileSSHD(dev)
		horust := g.installHorust(sshd)
		starship := g.compileStarship(horust)
		userGroup := g.compileUserGroup(starship)
		aptMirror = userGroup
	}

to use apt mirror.

In my PC, I've conducted some tests with build.envd

    base(image="ubuntu:22.04",dev=True)
    install.conda()
    install.python()
    install.python_packages(requirements="requirements/dev.txt")
    runtime.init(["make install"])

Before:

build from scratch

install builtin packages costs 358s and envd up cost 8min20s overall.

build from cache

envd up cost 2min10s overall.

After

build from scratch

install builtin packages costs 26s and envd up cost 3min24s overall.

build from cache

envd up cost 2mins overall.

@n063h n063h requested review from aseaday and zwpaper as code owners April 10, 2023 02:41
@n063h
feat: bring apt-source compilation earlier
a47ec69 
Signed-off-by: Xing Lv <xlv20@fudan.edu.cn>
@n063h n063h force-pushed the adjustAptSourceLocation branch from 8e86f53 to a47ec69 Compare April 10, 2023 02:42
@n063h n063h mentioned this pull request Apr 10, 2023
Closed
@gaocegege
Copy link
Member

/assign @kemingy

@kemingy kemingy added this pull request to the merge queue Apr 10, 2023
Merged via the queue into tensorchord:main with commit e383395 Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemingy kemingy kemingy approved these changes

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees

@kemingy kemingy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n063h @gaocegege @kemingy
0