8000 fix: use buildkit container builder to export cache by kemingy · Pull Request #1975 · tensorchord/envd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use buildkit container builder to export cache #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix: use buildkit container builder to export cache #1975

merged 2 commits into from
Feb 7, 2025

Conversation

kemingy
Copy link
Member
@kemingy kemingy commented Feb 7, 2025

@kemingy
fix: use buildkit container builder to export cache
6ea95ff 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy kemingy requested review from gaocegege and Copilot February 7, 2025 15:40
Copilot
Copilot AI reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • base-images/remote-cache/build-and-push-remote-cache.sh: Language not supported
  • base-images/remote-cache/build.envd: Language not supported
  • pkg/app/up.go: Evaluated as low risk
  • pkg/builder/build.go: Evaluated as low risk
  • README.md: Evaluated as low risk
Comments suppressed due to low confidence (1)

pkg/lang/ir/v1/r.go:28

  • The removal of the 'apt-get update' command might cause issues if it was necessary for the subsequent commands to work correctly.
apt-get update && apt-get install -y --no-install-recommends --fix-missing gpg &&

@kemingy
fix lint
a244de4 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy kemingy added this pull request to the merge queue Feb 7, 2025
@gaocegege
8000 Copy link
Member

You wake up so early

Merged via the queue into tensorchord:main with commit 37cb376 Feb 7, 2025
13 checks passed
@kemingy kemingy deleted the use_docker_export_cache branch February 7, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@gaocegege gaocegege gaocegege approved these changes

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

@VoVAllen VoVAllen Awaiting requested review from VoVAllen VoVAllen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: cannot export cache with moby builder
2 participants
@kemingy @gaocegege
0