8000 feat: emb the whole template/*.envd, avoid random map key order by kemingy · Pull Request #1995 · tensorchord/envd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: emb the whole template/*.envd, avoid random map key order #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

feat: emb the whole template/*.envd, avoid random map key order #1995

merged 1 commit into from
Mar 11, 2025

Conversation

kemingy
Copy link
Member
@kemingy kemingy commented Mar 11, 2025

@kemingy
feat: emb the whole template/*.envd, avoid random map key order
d79a145 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy kemingy requested a review from Copilot March 11, 2025 07:30
@kemingy kemingy requested review from aseaday and zwpaper as code owners March 11, 2025 07:30
Copilot
Copilot AI reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the embedding strategy for template files by replacing a hard-coded map with dynamic loading of all "*.envd" files from the template directory.

  • Replaces explicit go:embed directives with a wildcard to include all templates.
  • Introduces a new EnvdTemplate struct and dynamic initialization logic.
  • Updates usage messages and file writing logic for managing templates.

Reviewed Changes

File Description
pkg/app/new.go Dynamically loads envd template files using embed.FS and updates related logic.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@kemingy kemingy added this pull request to the merge queue Mar 11, 2025
Merged via the queue into tensorchord:main with commit a78a245 Mar 11, 2025
11 checks passed
934D
@kemingy kemingy deleted the embed_templates branch March 11, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@gaocegege gaocegege gaocegege approved these changes

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kemingy @gaocegege
0