8000 fix: locale for both dev=True/False by kemingy · Pull Request #2010 · tensorchord/envd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: locale for both dev=True/False #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

fix: locale for both dev=True/False #2010

merged 1 commit into from
Apr 2, 2025

Conversation

kemingy
Copy link
Member
@kemingy kemingy commented Apr 1, 2025

@kemingy
fix: locale for both dev=True/False
3b2fdb4 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy kemingy requested review from gaocegege and Copilot April 1, 2025 14:59
Copilot
Copilot AI reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts locale settings to use C.UTF-8 across the codebase, reverts previous en_US.UTF-8 settings, and updates the default miniconda version.

  • Change locale variables from en_US.UTF-8 to C.UTF-8 in environment setup
  • Remove the locale-gen command from the apt installation flow to align with the new locale setting
  • Update the default miniconda version in the conda configuration

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
pkg/types/envd.go Updated LANG and LC_ALL values to maintain consistent locale usage
pkg/lang/ir/v1/system.go Removed the locale-gen command to avoid generating en_US.UTF-8
pkg/lang/ir/v1/conda.go Updated condaVersionDefault for a newer miniconda version
pkg/lang/ir/v1/compile.go Adjusted LC_ALL environment variable to match the new locale
Files not reviewed (1)
  • pkg/lang/ir/v1/get_conda.sh: Language not supported

@kemingy
Copy link
Member Author
kemingy commented Apr 1, 2025

The difference between C. and en_US. primarily affects formatting rules (like dates, numbers, currency) and collation (sorting order). It does not affect the ability to encode or decode specific characters, as long as the encoding is declared as UTF-8.

@gaocegege gaocegege enabled auto-merge April 2, 2025 00:21
@gaocegege gaocegege added this pull request to the merge queue Apr 2, 2025
Merged via the queue into tensorchord:main with commit 8514a4a Apr 2, 2025
11 checks passed
@kemingy kemingy deleted the locale branch April 2, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@gaocegege gaocegege gaocegege approved these changes

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

@VoVAllen VoVAllen Awaiting requested review from VoVAllen VoVAllen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kemingy @gaocegege
0