8000 Move jupyter notebook installation to envdlib by oubotong · Pull Request #15 · tensorchord/envdlib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move jupyter notebook installation to envdlib #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 33 commits into from
Closed

Move jupyter notebook installation to envdlib #15

wants to merge 33 commits into from

Conversation

oubotong
Copy link
Contributor
@oubotong oubotong commented Dec 1, 2022 •
edited
Loading

As suggested in the feat: support serving #1228

  • config.jupyter() move to envdlib (Done)

To test this PR, simply do:

envdlib = include("https://github.com/tensorchord/envdlib")
def build():
    base(os="ubuntu20.04", language="python3")
    envdlib.jupyter_notebook(8888, 8888) #Or any port mapping you want

@muniu-bot
Copy link
Contributor
muniu-bot bot commented Dec 1, 2022

Welcome @oubotong! It looks like this is your first PR to tensorchord/envdlib 🎉

@kemingy
Copy link
Member
kemingy commented Dec 1, 2022

I think these two notebook functions can be put in the same file. You don't have to use different files for different functions.

@oubotong
10000
Copy link
Contributor Author
oubotong commented Dec 1, 2022

I think these two notebook functions can be put in the same file. You don't have to use different files for different functions.

Yes, make sense. Let me fix it

@oubotong
Move jupyter notebook into envdlib
cfde843 
Signed-off-by: Botong <richard97@g.ucla.edu>
kemingy
kemingy reviewed Dec 1, 2022
View reviewed changes
@oubotong
Remove jinja2
2bd07d1 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Remove --alow-root option
5f9c755 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Create jupypter.envd
3810a99 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Update jupypter.envd
7f1636d 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Update jupypter.envd
cde19f7 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Update jupypter.envd
e8add18 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Update jupypter.envd
fca1741 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Update jupypter.envd
e79c5be 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Update jupypter.envd
07dd785 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Update jupypter.envd
766e717 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Update jupypter.envd
801f9f9 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Update jupypter.envd
c08bb0d 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Rename notebook.envd to jupyter-lab.envd
e41f138 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Rename jupypter.envd to jupypter-notebook.envd
174fffb 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Rename jupypter-notebook.envd to jupyter-notebook.envd
3dc8e52 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Move jupyter notebook into envdlib
09c295a 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Remove jinja2
e0884fc 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Format the codes
a37f3aa 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong
Format the codes
3472a87 
Signed-off-by: Botong <richard97@g.ucla.edu>
@oubotong oubotong closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemingy kemingy kemingy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oubotong @kemingy
0