10000 Abandon gerrit and use github for everything · Issue #94 · tensorflow/tensorflow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Abandon gerrit and use github for everything #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
resouer opened this issue Nov 10, 2015 · 14 comments
Closed

Abandon gerrit and use github for everything #94

resouer opened this issue Nov 10, 2015 · 14 comments
Labels
type:feature Feature requests

Comments

@resouer
Copy link
resouer commented Nov 10, 2015

Gerrit review workflow is very hard to maintain and follow. A lot of project abandoned it and turns to github finally.

Really hope tensorflow will use github for all the cooperation workflow. Google Kubernetes and Docker are all excellent examples for how to use github maintain a huge and global scale open source project successfully.

github + travis CI + slack is awesome. Just make everything be a PR :)

@graphific
Copy link

👍

5 similar comments
@jrabary
Copy link
jrabary commented Nov 10, 2015

+1

@RicoAntonioFelix
Copy link

👍

@ruffsl
Copy link
ruffsl commented Nov 10, 2015

👍

@anjishnu
Copy link

+1

@mavenlin
Copy link
Contributor

+1

@vrv
Copy link
8000
vrv commented Nov 11, 2015

We hear you all -- the current workflow is not ideal and is a pain for us too. There are several reasons why we can't just switch solely to github today, but since it is a pain for us, we're motivated to try to make things better :).

We'll keep this bug open to track the request.

@pineking
Copy link

+1

@resouer
Copy link
Author
resouer commented Nov 11, 2015

@vrv Thanks. btw, if you guys need any help, please fire up related issues, add "help-needed" and area label, and I think all the guys here are eager to fix them :)

@bhack
Copy link
Contributor
bhack commented Nov 11, 2015

👍

2 similar comments
@cgel
Copy link
cgel commented Nov 11, 2015

+1

@jsnel
Copy link
jsnel commented Nov 11, 2015

+1

@vrv
Copy link
vrv commented Nov 12, 2015

De-duping with #26

@vrv vrv closed this as completed Nov 12, 2015
@vrv vrv added the duplicate label Nov 12, 2015
@Dominator008
Copy link

In my opinion doing code review on GitHub is horrible except for very small fixes / tweaks. In addition, all those merge commits from "pull requests" really clutter up the git log.

Blaze (Bazel) uses both Gerrit and GitHub. All external pull requests are not merged directly, but committed through the Gerrit repo. As a result, their commit history looks much cleaner: https://github.com/bazelbuild/bazel/commits/master.

Would you consider keeping a Gerrit mirror and possibly using the Gerrrit-GitHub plugin https://gerrit.googlesource.com/plugins/github/+/master/README.md?

@aselle aselle added type:feature Feature requests and removed enhancement labels Feb 9, 2017
benoitsteiner pushed a commit that referenced this issue Jun 29, 2017
* [OpenCL] Cleans cwise ops

* [OpenCL] Reduces noise in the pull request

* [OpenCL] Uncomment SqrtGrad registration for SYCL

* [OpenCL] Registers RsqrtGrad (#94)

* [OpenCL] Registers RsqrtGrad

* fixed typo
allenlavoie pushed a commit to allenlavoie/tensorflow that referenced this issue Jul 15, 2017
* [OpenCL] Cleans cwise ops

* [OpenCL] Reduces noise in the pull request

* [OpenCL] Uncomment SqrtGrad registration for SYCL

* [OpenCL] Registers RsqrtGrad (tensorflow#94)

* [OpenCL] Registers RsqrtGrad

* fixed typo
lukeiwanski pushed a commit to codeplaysoftware/tensorflow that referenced this issue Oct 26, 2017
* [OpenCL] Registers RsqrtGrad

* fixed typo
lukeiwanski pushed a commit to codeplaysoftware/tensorflow that referenced this issue Oct 26, 2017
* [OpenCL] Registers RsqrtGrad

* fixed typo
eggonlea pushed a commit to eggonlea/tensorflow that referenced this issue Mar 12, 2019
8000
Including memmapped_file_system for Windows in the BUILD file
tensorflow-copybara pushed a commit that referenced this issue Aug 20, 2019
Support (de)serialization of spv.struct with offset decorations.

Closes #94

COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#94 from denis0x0D:sandbox/struct_serialize 16a7d63fd23bf5ec90c1c83d4330a4646e6ff787
PiperOrigin-RevId: 264421427
xinan-jiang pushed a commit to xinan-jiang/tensorflow that referenced this issue Oct 4, 2019
Support (de)serialization of spv.struct with offset decorations.

Closes tensorflow#94

PiperOrigin-RevId: 264421427
cjolivier01 pushed a commit to Cerebras/tensorflow that referenced this issue Dec 6, 2019
…stream-sync-180730

Develop upstream sync 180730

Merging even though there is one failure.
antkillerfarm added a commit to antkillerfarm/tensorflow that referenced this issue Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

0