-
Notifications
You must be signed in to change notification settings - Fork 74.7k
Abandon gerrit and use github for everything #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👍 |
5 similar comments
+1 |
👍 |
👍 |
+1 |
+1 |
We hear you all -- the current workflow is not ideal and is a pain for us too. There are several reasons why we can't just switch solely to github today, but since it is a pain for us, we're motivated to try to make things better :). We'll keep this bug open to track the request. |
+1 |
@vrv Thanks. btw, if you guys need any help, please fire up related issues, add "help-needed" and area label, and I think all the guys here are eager to fix them :) |
👍 |
2 similar comments
+1 |
+1 |
De-duping with #26 |
In my opinion doing code review on GitHub is horrible except for very small fixes / tweaks. In addition, all those merge commits from "pull requests" really clutter up the git log. Blaze (Bazel) uses both Gerrit and GitHub. All external pull requests are not merged directly, but committed through the Gerrit repo. As a result, their commit history looks much cleaner: https://github.com/bazelbuild/bazel/commits/master. Would you consider keeping a Gerrit mirror and possibly using the Gerrrit-GitHub plugin https://gerrit.googlesource.com/plugins/github/+/master/README.md? |
* [OpenCL] Cleans cwise ops * [OpenCL] Reduces noise in the pull request * [OpenCL] Uncomment SqrtGrad registration for SYCL * [OpenCL] Registers RsqrtGrad (#94) * [OpenCL] Registers RsqrtGrad * fixed typo
* [OpenCL] Cleans cwise ops * [OpenCL] Reduces noise in the pull request * [OpenCL] Uncomment SqrtGrad registration for SYCL * [OpenCL] Registers RsqrtGrad (tensorflow#94) * [OpenCL] Registers RsqrtGrad * fixed typo
* [OpenCL] Registers RsqrtGrad * fixed typo
* [OpenCL] Registers RsqrtGrad * fixed typo
Including memmapped_file_system for Windows in the BUILD file
Support (de)serialization of spv.struct with offset decorations. Closes #94 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#94 from denis0x0D:sandbox/struct_serialize 16a7d63fd23bf5ec90c1c83d4330a4646e6ff787 PiperOrigin-RevId: 264421427
Support (de)serialization of spv.struct with offset decorations. Closes tensorflow#94 PiperOrigin-RevId: 264421427
…stream-sync-180730 Develop upstream sync 180730 Merging even though there is one failure.
Gerrit review workflow is very hard to maintain and follow. A lot of project abandoned it and turns to github finally.
Really hope tensorflow will use github for all the cooperation workflow. Google Kubernetes and Docker are all excellent examples for how to use github maintain a huge and global scale open source project successfully.
github + travis CI + slack is awesome. Just make everything be a PR :)
The text was updated successfully, but these errors were encountered: