8000 Add the shared libraries in the quickstart by superryanguo · Pull Request #10871 · tensorflow/tensorflow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add the shared libraries in the quickstart #10871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2017
Merged

Add the shared libraries in the quickstart #10871

merged 2 commits into from
Jun 22, 2017

Conversation

superryanguo
Copy link
Contributor

When following the quickstart steps of the golang README.md, below issue is found:

$ uname -a
Linux ubuntu-16 4.4.0-57-generic #78-Ubuntu SMP Fri Dec 9 23:50:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
$ go test github.com/tensorflow/tensorflow/tensorflow/go
/tmp/go-build828413616/github.com/tensorflow/tensorflow/tensorflow/go/_test/go.test: error while loading shared libraries: libtensorflow.so: cannot open shared object file: No such file or directory
FAIL github.com/tensorflow/tensorflow/tensorflow/go 0.001s

It's due to the env variable, after adding the LIBRARY_PATH and LD_LIBRARY_PATH, it became ok.

$ go test github.com/tensorflow/tensorflow/tensorflow/go
ok github.com/tensorflow/tensorflow/tensorflow/go 0.246s

so I updated the README.md file.

@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@superryanguo
Copy link
Contributor Author

I signed it! cla

@googlebot
Copy link

CLAs look good, thanks!
8000

asimshankar
asimshankar suggested changes Jun 21, 2017
View reviewed changes
Copy link
Contributor
@asimshankar asimshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Some suggestions.

tensorflow/go/README.md Outdated
@@ -26,6 +26,8 @@ Construct and execute TensorFlow graphs in Go.
curl -L \
"https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-${TF_TYPE}-$(go env GOOS)-x86_64-1.1.0.tar.gz" |
sudo tar -C /usr/local -xz
export LIBRARY_PATH=$LIBRARY_PATH:/usr/local/lib
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of setting the environment variables, perhaps we can just run ldconfig?

Actually, better still, perhaps it would be better to replace the "Quickstart" section with a pointer to the installation instructions on the website: https://www.tensorflow.org/install/install_go ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! We can totally replace the "Quickstart" with the web link since there's also a section "Installing into locations other than /usr/local " under it, which can make the whole file terse.

@asimshankar asimshankar self-assigned this Jun 21, 2017
@yifeif yifeif added the stat:awaiting response Status - Awaiting response from author label Jun 21, 2017
asimshankar
asimshankar approved these changes Jun 22, 2017
View reviewed changes
Copy link
Contributor
@asimshankar asimshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asimshankar
Copy link
Contributor

Jenkins, test this please.

@asimshankar asimshankar added awaiting testing (then merge) and removed stat:awaiting response Status - Awaiting response from author labels Jun 22, 2017
@yifeif yifeif merged commit df6a235 into tensorflow:master Jun 22, 2017
allenlavoie pushed a commit to allenlavoie/tensorflow that referenced this pull request Jul 15, 2017
@yifeif
Merge pull request tensorflow#10871 from superryanguo/master
dcd6baf 
Add the shared libraries in the quickstart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimshankar asimshankar asimshankar approved these changes

Assignees

@asimshankar asimshankar

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@superryanguo @tensorflow-jenkins @googlebot @asimshankar @yifeif
0