8000 Implement tf.layers.dot() for 4D (Dot Merge Layer) · Issue #19 · tensorflow/tfjs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement tf.layers.dot() for 4D (Dot Merge Layer) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
caisq opened this issue Mar 27, 2018 · 11 comments
Closed

Implement tf.layers.dot() for 4D (Dot Merge Layer) #19

caisq opened this issue Mar 27, 2018 · 11 comments
Assignees
@pyu10055 @gaikwadrahul8
Labels
comp:layers P3 stat:awaiting response type:feature New feature or request

Comments

@caisq
Copy link
Contributor
caisq commented Mar 27, 2018 •
edited
Loading

The PyKeras code is at: https://github.com/keras-team/keras/blob/master/keras/layers/merge.py#L408
@caisq caisq added type:feature New feature or request comp:layers labels Mar 27, 2018
@HassanAzzam
Copy link

When will it be available?

@caisq
Copy link
Contributor Author
caisq commented Apr 14, 2018

Thanks, @HassanAzzam

Just for my curiosity: what model are you planning to write or port that requires Dot?

@HassanAzzam
Copy link

Currently, trying to practice it on a skip-gram model.

@caisq caisq added the good first issue Good for newcomers label Apr 15, 2018
@caisq
Copy link
Contributor Author
caisq commented Apr 15, 2018

Thanks, @HassanAzzam . We'll prioritize adding Dot.

@HassanAzzam
Copy link

Thanks alot, @caisq😃

@euler16
Copy link
Contributor
euler16 commented Oct 13, 2018

is anyone working on this issue? if not then I would like to try working on it. In that case @caisq could you give me some pointers to start.

@caisq
Copy link
Contributor Author
caisq commented Oct 13, 2018

@euler16 The just released v0.13.2 should have tf.layers.dot included. Please give it a try. Note that it currently doesn't support 4D or higher dimensions as inputs.

@caisq
Copy link
Contributor Author
caisq commented Oct 13, 2018

I'm leaving this issue open because the support for 4D+ cases is not implemented yet.

@nsthorat nsthorat changed the title Implement tf.layers.dot() (Dot Merge Layer) Implement tf.layers.dot() for 4D (Dot Merge Layer) Oct 24, 2018
@nsthorat nsthorat added P3 help wanted and removed good first issue Good for newcomers labels Oct 24, 2018
nsthorat pushed a commit that referenced this issue Aug 19, 2019
@nkreeger
Store only TFE_TensorHandle pointers. (#19)
5cda7ec 
* wip

* wip

* wip

* wip

* Cleanup.

* Format.

* Use `type` instead of `class`.

* Cleanup from review.
nsthorat pushed a commit that referenced this issue Aug 20, 2019
@tafsiri
export types to improve ts dev exprience (#19)
3180720 
closes #17
@gaikwadrahul8 gaikwadrahul8 self-assigned this Aug 10, 2023
@gaikwadrahul8
Copy link
Contributor

Hi, @caisq

Apologize for the delayed response and I was trying to use tensors of 4D or higher rank and I was getting this error message Dot layer does not support tensors of 4D or higher rank yet. so it seems like we haven't implemented this feature request yet. Thank you!

image

@gaikwadrahul8
Copy link
Contributor

Hi, @caisq

Thank you for opening this issue for tracking purposes. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.

The TFJs team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TFJs version with the latest compatible hardware configuration which could potentially resolve the issue. We can keep the issue open if it is still relevant. Please confirm if we need to keep the issue open.

Thank you for your support and cooperation.

@gaikwadrahul8
Copy link
Contributor

Hi, @caisq

We have not received any confirmation from you, so we are closing this issue now. If the issue is still relevant, please let us know, either we'll re-open this issue or please feel free to create new issue after trying with latest version of Tensorflow.js. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pyu10055 pyu10055

@gaikwadrahul8 gaikwadrahul8

Labels
comp:layers P3 stat:awaiting response type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@pyu10055 @nsthorat @HassanAzzam @caisq @euler16 @rthadur @gaikwadrahul8
0