Make save_tcp reconnect on network outages #5230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16b1257 to
f6d8334
Compare
📚 Documentation Preview🧹 Preview deployment has been cleaned up The documentation preview for this PR has been removed since the PR was closed. |
ca89046 to
fed36b3
Compare
8000
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the save_tcp operator by adding automatic reconnection on recoverable errors, introduces new retry tuning options, and removes the legacy TQL1 TCP connector plugin.
- Adds an end-to-end test for
save_tcpreconnect behavior - Updates parsing error hints to drop the removed
tcploader option - Introduces a changelog entry for the reconnect feature
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tenzir/tests/exec/operators/save_tcp/reconnect.txt | Sample messages for reconnect test |
| tenzir/tests/exec/operators/save_tcp/reconnect.tql | TQL pipeline exercising reconnect and retry options |
| tenzir/bats/data/reference/pipelines_local/test_parse_operators/step_19.ref | Removed tcp from supported loader hint |
| tenzir/bats/data/reference/pipelines_local/test_parse_operators/step_15.ref | Removed tcp from supported loader hint |
| tenzir/bats/data/reference/pipelines_local/test_parse_operators/step_14.ref | Removed tcp from supported loader hint |
| changelog/changes/Ezv8Vz2A1XgON7euQJjkNvrhQM.md | New feature entry describing reconnect behavior |
Comments suppressed due to low confidence (1)
tenzir/tests/exec/operators/save_tcp/reconnect.tql:8
- [nitpick] Add a complementary test that configures and verifies the new
max_retry_delayandretry_timeoutoptions to ensure both settings are honored during reconnection.
save_tcp "0.0.0.0:3000", retry_delay=1s
raxyte
approved these changes
Jun 4, 2025
tenzir/bats/data/reference/pipelines_local/test_parse_operators/step_14.ref
Show resolved
Hide resolved
fed36b3 to
6af9b79
Compare
79e11c6 to
8d76b05
Compare
03473a3 to
8d76b05
Compare
76e4856 to
ab8ffab
Compare
e0ca0a5 to
1e84c90
Compare
This commit was partially vibe-coded. I only fixed up the accidental deletions that made the build break.
1e84c90 to
bb13715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
save_tcp(from "tcp://...") operator now tries to reconnect in case of recoverable errors such as network outages and in case the remote end disconnects.You can use the new options
retry_delay: durationandmax_retry_count: intto tune the behavior to your needs. The default values are set to 30 seconds and 10 times respectively.This PR also removes the TQL1 TCP connector plugin.