Support OCSF extensions in ocsf::apply
#5306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
jachris
added
feature
New functionality
operator
Source, transformation, and sink
labels
Jun 27, 2025
📚 Documentation Preview🧹 Preview deployment has been cleaned up The documentation preview for this PR has been removed since the PR was closed. |
c88ce06 to
642210f
Compare
642210f to
8817af3
Compare
dominiklohmann
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for OCSF extensions in the ocsf::apply operator by reading metadata.extensions alongside version and profiles, updates the schema generator to emit #extension attributes, and provides tests covering valid and invalid extension scenarios.
- ocsf::apply now filters fields by enabled extensions and emits warnings when extensions are malformed or missing
ocsf-schemas.pyemits#extensionannotations and writes enums/versions including extension metadata- Comprehensive TQL/JSON test cases for wrong and correct
metadata.extensionsusage
Reviewed Changes
Copilot reviewed 42 out of 43 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tenzir/tests/ocsf/*.tql & *.txt | Added tests for invalid and valid metadata.extensions shapes |
| scripts/ocsf-schemas.py | Emit #extension tags, generate versions/inc, update mangle |
| libtenzir/src/ocsf.cpp | Switch to versioned lookup with ocsf_version enum |
| libtenzir/include/tenzir/ocsf.hpp | Introduce ocsf_version enum and version-aware signatures |
| libtenzir/builtins/operators/ocsf.cpp | Apply extension filtering in caster and operator pipelines |
| libtenzir/builtins/functions/ocsf.cpp | Update mapping plugin to accept version parameter |
| docs/operators/ocsf/apply.md | Document metadata.extensions as a fourth input dimension |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ocsf::applyoperator now supports OCSF extensions. This means thatmetadata.extensionsis now also taken into account for casting and validation. At the moment, only the extensions versioned together with OCSF are supported. This includes thewinandlinuxextensions.