8000 Implement format and compression inference from URIs for HTTP by raxyte · Pull Request #5300 · tenzir/tenzir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement format and compression inference from URIs for HTTP #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

raxyte
Copy link
Member
@raxyte raxyte commented Jun 24, 2025

No description provided.

Copy link
github-actions bot commented Jun 24, 2025

📚 Documentation Preview

🧹 Preview deployment has been cleaned up

The documentation preview for this PR has been removed since the PR was closed.

@raxyte raxyte added the feature New functionality label Jun 24, 2025
@raxyte raxyte force-pushed the topic/http-inference branch from b8a7db2 to bdf88be Compare June 25, 2025 07:50
@raxyte raxyte requested a review from jachris June 25, 2025 12:15
@raxyte raxyte marked this pull request as ready for review June 25, 2025 12:16
@raxyte raxyte enabled auto-merge June 25, 2025 12:19
@raxyte raxyte force-pushed the topic/http-inference branch 4 times, most recently from 3125f9d to 0203839 Compare June 28, 2025 06:54
Copy link
Member
@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having read the changelog, it seems the logic now prefers the file extension over the content type. Is that the case? If not, we're good. But the Content-Type header is most of the time more accurate than the extension.

We could also allow the user to control the behavior in the future. For now, we just need to pick the most sensible setting.

@raxyte
Copy link
Member Author
raxyte commented Jun 30, 2025

@mavam See this for more info: https://tenzir.slack.com/archives/C04L7KXNZ9A/p1750758769154139?thread_ts=1750666508.920309&cid=C04L7KXNZ9A. TLDR: preference doesn't matter when they are both the same or we can only handle one of them. When they differ, we decided to go with filename for now and switch it if we encounter too many issues.

@mavam
Copy link
Member
mavam commented Jun 30, 2025

That sounds fine to me.

Important: this behavior must be well-documented.

@raxyte raxyte force-pushed the topic/http-inference branch 2 times, most recently from c678d35 to 71d383b Compare June 30, 2025 09:03
@raxyte raxyte force-pushed the topic/http-inference branch 5 times, most recently from 98a0c72 to f2c4431 Compare July 1, 2025 12:02
@raxyte raxyte force-pushed the topic/http-inference branch from f2c4431 to b79b758 Compare July 1, 2025 15:20
@raxyte raxyte force-pushed the topic/http-inference branch from b79b758 to a994198 Compare July 2, 2025 10:31
@raxyte raxyte merged commit f5c77fa into main Jul 2, 2025
105 of 109 checks passed
@raxyte raxyte deleted the topic/http-inference branch July 2, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0