Properly handle partition_transformer shutdown
#5301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚 Documentation Preview🧹 Preview deployment has been cleaned up The documentation preview for this PR has been removed since the PR was closed. |
cc6f0f2 to
9f8cba4
Compare
tobim
reviewed
Jun 24, 2025
partition_transformer` shutdownpartition_transformer shutdown
9f8cba4 to
1bedfb2
Compare
dominiklohmann
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR improves the shutdown process for partition transformers by adding monitoring and active management of those actors, ensuring a graceful and parallel shutdown to avoid hangs.
- Adds registration and monitoring of partition_transformer actors in the index state.
- Implements a new shutdown procedure that disposes monitors and shuts down all active transformers.
- Updates the changelog to document the shutdown hang fix.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libtenzir/src/index.cpp | Introduces monitoring and parallel shutdown for partition transformers. |
| libtenzir/include/tenzir/index.hpp | Adds active_transformers map with detailed documentation for transformer actors. |
| changelog/changes/centre-backed-agree.md | Documents the bugfix for the shutdown hang in partition rebuild scenarios. |
Comments suppressed due to low confidence (1)
libtenzir/src/index.cpp:1560
- The variable 'partition_transfomer' appears to be misspelled; consider renaming it to 'partition_transformer' for clarity.
std::move(partition_synopsis_path_template));
The index actor keeps track of all currently running `partition_transformer`s and properly shuts them down.
1bedfb2 to
8976f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index actor keeps track of all currently running
partition_transformers and properly shuts them down.