Improve MSB diagnostics #5319
Draft
Improve MSB diagnostics #5319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now actually have multi-match between different types, we can use the much nicer implementation. This commit is mainly just enabling the already existing, commented out implementation.
This allows for better error messages, mentioning the fieldname on type conflicts.
|
Tip Please add a changelog entry for this PR by clicking one of the links below. The changelog entry will be pre-filled with information from this PR. You can edit the title and description as needed before committing. You can also add a changelog entry manually by running 📝 Changelog Entries
📚 Documentation Preview✅ Docs preview is ready! 🔗 Preview Docs: https://tenzir-tenzir-preview-5319.surge.sh The preview will be updated automatically when you push new commits to this PR. |
jachris
reviewed
Jul 3, 2025
Comment on lines
+61
to
+65
| if (is_extension) { | ||
| path_->append(size_t{1}, '.'); | ||
| } | ||
| path_->append(field_name); | ||
| return view{path_, field_name.size() + is_extension}; |
There was a problem hiding this comment.
Did you consider forming a chain instead of modifying the original? This looks very easy to misuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds field path tracking to the MSB, allowing for better diagnostics.