8000 Add getSignal() to TabContainer by CasualYT31 · Pull Request #204 · texus/TGUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add getSignal() to TabContainer #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2023
Merged

Add getSignal() to TabContainer #204

merged 2 commits into from
Aug 30, 2023

Conversation

CasualYT31
Copy link
Contributor

The TabContainer did not have an implementation for Widget::getSignal(). This caused invoking getSignal("SelectionChanged") and getSignal("SelectionChanging") on Widget objects to throw exceptions.

Now, both invocations can be made and signal handlers can be connected. Widget signals can still be accessed, too.

@texus
Copy link
Owner
texus commented Aug 30, 2023

Thanks. This issue also seems to exist in SpinControl, could you perhaps add another commit to fix it there as well?

@CasualYT31
Copy link
Contributor Author

Thanks. This issue also seems to exist in SpinControl, could you perhaps add another commit to fix it there as well?

Sure, I'll get it done within the next few hours. Should've checked to be fair.

@texus texus merged commit ef23452 into texus:1.x Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CasualYT31 @texus
0