MessageBox: add changeButtons() (addresses #214) #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasualYT31
commented
Sep 2, 2023
| ///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// | ||
| /// Adds a button to the MessageBox. | ||
| ///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// | ||
| void addButtonImpl(const String& caption); |
There was a problem hiding this comment.
I separated addButton()'s code in this way to prevent rearranging the MessageBox more than necessary when using changeButtons() to add multiple buttons.
14eb711 to
ce74623
Compare
|
Force push was to add issue number to the commit message. |
ce74623 to
504348a
Compare
504348a to
9e578d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the docstring for a rundown of the behaviour of the new method. I have also added tests.