[#233] clean up and make new release #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sras
reviewed
Sep 9, 2021
src/base_DAO.mligo
Outdated
| @@ -40,8 +38,7 @@ let allowing_xtz (param, store, config : allow_xtz_params * storage * config) = | |||
| | Accept_ownership -> accept_ownership(store) | |||
|
|
|||
| (* | |||
| * The actual DAO contract, which in this version is the same independently from | |||
| * the DAO logic. | |||
| * The actual DAO contract, which is the same independently from the DAO logic. | |||
There was a problem hiding this comment.
- The actual DAO contract, which is the same independently from the DAO logic.
May be we can further rephrase it as "which is the same, despite the specific DAO logic included", or something simlar.
sras
reviewed
Sep 9, 2021
src/treasuryDAO/types.mligo
Outdated
| type treasury_dao_transfer_proposal = | ||
| { agora_post_id : nat | ||
| ; transfers : transfer_type list | ||
| } | ||
|
|
||
| // Treasury dao `proposal_metadata`, defining the type its proposals. |
There was a problem hiding this comment.
defining the type its proposals.
'of' is probably missing here after 'type'.
sras
approved these changes
Sep 9, 2021
Problem: the snapshot file for stack is used as a resolver in a single stack.yaml, so it can be removed for simplification. Additionally, the lorentz dependency is slightly old (by a minor version). Solution: remove the snapshot, update and clean up stack.yaml.
Problem: the last tested ligo version is outdated. Solution: update the LIGO version to the latest available.
Problem: some license headers are outdated and reference 2020. Solution: update licence headers to 2021.
Problem: there are some typos and inconsistencies in LIGO comments. Solution: clean up the comments and re-order some code.
Problem: currently we do not state in the Haskell's build system that there are `.tz` files we want to depend on, we only call `qAddDependentFile` (or a function that uses it). This way the file is indeed fetched, however once the project is built, `cabal`/`stack` do not know that the module that fetches the contract or the test storages has to be rebuild when `.tz` files changes. Solution: add the .tz files to `extra-source-files` section of `package.yaml` and move `README.md` to a separate `extra-doc-files` section. Additionally, remove env var and refactor some code as a consequence.
a448146 to
d50ec2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several small adjustments and version number bump.
This follows the addition of better tests and the now stable contract logic.
See relative commit messages for an explanation on the changes.
Related issue(s)
Resolves #233
✅ Checklist for your Pull Request
Related changes (conditional)
silently reappearing again.
Stylistic guide (mandatory)