Refactor some stuff related to quirk processing #89075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
commented
Jan 14, 2025
| @@ -7,17 +7,13 @@ | |||
| hardcore_value = 5 | |||
| quirk_flags = QUIRK_HUMAN_ONLY|QUIRK_PROCESSES | |||
| mail_goodies = list(/obj/item/reagent_containers/syringe/convermol) // to help breathing | |||
| minimum_process_stat = CONSCIOUS | |||
| no_process_traits = list(TRAIT_MIND_TEMPORARILY_GONE, TRAIT_FEARLESS, TRAIT_KNOCKEDOUT) | |||
There was a problem hiding this comment.
technically, minimum_process_stat = CONSCIOUS should handle this just fine, but I added TRAIT_KNOCKEDOUT here just to be 1:1 with the original code.
ZephyrTFA
reviewed
Jan 19, 2025
code/datums/quirks/_quirk.dm
Outdated
Comment on lines
47
to
50
| if(no_process_traits) | ||
| LAZYINITLIST(process_update_signals) | ||
| for(var/trait in no_process_traits) | ||
| process_update_signals += list(SIGNAL_ADDTRAIT(trait), SIGNAL_REMOVETRAIT(trait)) |
There was a problem hiding this comment.
you only need the for loop.
for(_ in null) is a noop
There was a problem hiding this comment.
fair, it was mostly to avoid the unneeded LAZYINITLIST - but I can just do LAZYADD, looking back
201e7ac to
d416226
Compare
Absolucy
added a commit
to Absolucy/tgstation
that referenced
this pull request
Jan 28, 2025
)" This reverts commit 8eaa934.
Absolucy
added a commit
to Absolucy/Monkestation
that referenced
this pull request
Feb 1, 2025
Ports my additional refactors from tgstation/tgstation#89075, and the fix from tgstation/tgstation#89265
Absolucy
added a commit
to Absolucy/Monkestation
that referenced
this pull request
Feb 1, 2025
Ports my additional refactors from tgstation/tgstation#89075, and the fix from tgstation/tgstation#89265
Absolucy
added a commit
to Absolucy/Monkestation
that referenced
this pull request
Feb 1, 2025
Ports my additional refactors from tgstation/tgstation#89075, and the fix from tgstation/tgstation#89265
Absolucy
added a commit
to Monkestation/Monkestation2.0
that referenced
this pull request
Feb 1, 2025
Ports my additional refactors from tgstation/tgstation#89075, and the fix from tgstation/tgstation#89265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Several quirks that process have some common checks and patterns: only processing if the mob's stat is conscious or not dead, or not processing if they have certain traits.
This refactors quirk processing so those checks are a part of
/datum/quirkitself, and the quirk will automatically be start/stop being processed bySSquirksbased on those conditions, by registering signals to re-check if the quirk should be processing or not.This ports said refactor from my downstream PR, Monkestation/Monkestation2.0#4642 (and is unaffected by the bug that Monkestation/Monkestation2.0#4836 fixes, due to additional refactors regarding trait handling)
Why It's Good For The Game
Less repetitive code is always better, and leaves less room for errors. Also, completely stopping the quirk from being processed by
SSquirkscan save a minuscule amount of CPU time.Changelog
🆑
refactor: Refactored how quirks handle starting/stopping processing.
/:cl: