Fix FloatingUI elements position when used scaling #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added
position: relativeto body element, which havescaleproperty when it needsIt fixes miss positioned tooltips, dropdowns etc.
Fix src - floating-ui/floating-ui#3032 (comment)
Fixes #178
Before
Y57csSpbv1.mp4
After
coaFvihYei.mp4
Also floating elements now created inside container with id
tgui-rootwhich must be before Layout componentIf document has no element with id
tgui-root, floating will create it on bottom ofbodyWhy's this needed?
Fixing scaling issue and geting rid of floating in body (if you add
tgui-rootid)