8000 Making append function by Sindorman · Pull Request #12 · tgstation/rust-g · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Making append function #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2018
Merged

Making append function #12

merged 4 commits into from
Oct 20, 2018

Conversation

Sindorman
Copy link
Contributor
@Sindorman Sindorman commented Oct 15, 2018 •
edited
Loading

This PR adds append function for the file. Fixes #8

8000
@SpaceManiac
Copy link
Contributor

I think I would prefer if we added a new function file_append and changed the text2file override to use that. There's some use in keeping the overwriting version around (namely, it can replace any fdel-text2file sequence). Thoughts?

@Sindorman
Copy link
Contributor Author

I have got no problem with it. @SpaceManiac . Changed.

@Sindorman Sindorman changed the title Fixing write to append Making append function Oct 16, 2018
@SpaceManiac
Copy link
Contributor

Looks good so far. The new function needs an entry in build.rs under the // module: file section, and the text2file override should use that new function instead.

@SpaceManiac
Copy link
Contributor

Code looks good. I'll test it when I can.

SpaceManiac
SpaceManiac suggested changes Oct 19, 2018
View reviewed changes
@SpaceManiac @Sindorman
mut
a35b181 
Co-Authored-By: Sindorman <mikebykhovtsev@gmail.com>
@SpaceManiac SpaceManiac merged commit af240a9 into tgstation:master Oct 20, 2018
@SpaceManiac SpaceManiac mentioned this pull request Dec 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceManiac SpaceManiac SpaceManiac approved these changes

Assignees

@SpaceManiac SpaceManiac

Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sindorman @SpaceManiac @tgstation-server
0