8000 refactor `Plugin` to allow async creation, refactor main `Gateway`, benchmark fixes by dotansimha · Pull Request #238 · the-guild-org/conductor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 18, 2025. It is now read-only.

refactor Plugin to allow async creation, refactor main Gateway, benchmark fixes #238

Merged
merged 16 commits into from
Dec 28, 2023
Merged

refactor Plugin to allow async creation, refactor main Gateway, benchmark fixes #238

merged 16 commits into from
Dec 28, 2023

Conversation

dotansimha
Copy link
Member
@dotansimha dotansimha commented Dec 26, 2023 •
edited
Loading

closes #224

  • Add CreatablePlugin definition
  • Allow plugins to initialize async
  • Refactor Actix entrypoint to handle async plugins
  • Refactor WASM entry to handle async plugins
  • Drop EndpointRuntime because it's unused
  • Better error handling around Plugins
  • Fix tests
  • CI

@dotansimha dotansimha force-pushed the improve-plugins branch 3 times, most recently from d626c58 to ee003c2 Compare December 26, 2023 15:20
@dotansimha dotansimha marked this pull request as ready for review December 26, 2023 15:20
@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 26, 2023 •
edited
Loading

✅ Benchmark Results

     data_received..................: 62 MB   776 kB/s
     data_sent......................: 98 MB   1.2 MB/s
     http_req_blocked...............: avg=2.32µs  min=762ns    med=1.95µs  max=14.93ms  p(90)=2.25µs  p(95)=2.49µs 
     http_req_connecting............: avg=85ns    min=0s       med=0s      max=2.42ms   p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=27.31ms min=788.89µs med=26.73ms max=117.95ms p(90)=43.91ms p(95)=50.6ms 
       { expected_response:true }...: avg=27.31ms min=788.89µs med=26.73ms max=117.95ms p(90)=43.91ms p(95)=50.6ms 
   ✓ http_req_failed................: 0.00%   ✓ 0           ✗ 255423
     http_req_receiving.............: avg=31.73µs min=9.7µs    med=25.67µs max=30.02ms  p(90)=38.29µs p(95)=42.18µs
     http_req_sending...............: avg=16.51µs min=4.93µs   med=11.17µs max=35.09ms  p(90)=14.29µs p(95)=21.24µs
     http_req_tls_handshaking.......: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=27.27ms min=749.94µs med=26.69ms max=117.92ms p(90)=43.85ms p(95)=50.54ms
     http_reqs......................: 255423  3192.766845/s
     iteration_duration.............: avg=27.41ms min=856.56µs med=26.83ms max=118.02ms p(90)=44.01ms p(95)=50.7ms 
     iterations.....................: 255423  3192.766845/s
   ✓ valid_graphql_response.........: 100.00% ✓ 255423      ✗ 0     
   ✓ valid_http_code................: 100.00% ✓ 255423      ✗ 0     
     vus............................: 1       min=1         max=100 
     vus_max........................: 100     min=100       max=100

@dotansimha dotansimha force-pushed the improve-plugins branch 3 times, most recently from 7c3776f to c9a5691 Compare December 27, 2023 06:27
@dotansimha dotansimha mentioned this pull request Dec 27, 2023
Closed
3 tasks
YassinEldeeb
YassinEldeeb reviewed Dec 27, 2023
View reviewed changes
YassinEldeeb
YassinEldeeb reviewed Dec 27, 2023
View reviewed changes
dotansimha and others added 4 commits December 27, 2023 17:28
@dotansimha
fixes
9abea7c 
ok we are getting there

ok

ok

tiny adjustments to k6 setup

try something

added engine only bench

more tracing
@dotansimha @YassinEldeeb
Update .github/workflows/benchmark.yaml
3b629d5 
Co-authored-by: Yassin Eldeeb <yassineldeeb94@gmail.com>
@dotansimha
update CONCURRENCY_LEVEL
71cc1c5
@dotansimha
update k6 threshold until we'll figure this out
ca10c15
YassinEldeeb
YassinEldeeb reviewed Dec 27, 2023
View reviewed changes
Copy link
Contributor
@YassinEldeeb YassinEldeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!!! 🚀 (in borat voice)

giphy

@dotansimha dotansimha changed the title refactor Plugin to allow async creation, refactor main Gateway refactor Plugin to allow async creation, refactor main Gateway, benchmark fixes Dec 27, 2023
@dotansimha dotansimha merged commit dcc2d71 into master Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YassinEldeeb YassinEldeeb YassinEldeeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin trait needs to have constraints of the config type and allow to init async
2 participants
@dotansimha @YassinEldeeb
0